search

day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
796 stars 147 forks source link

The validation of the the modal parts is inconsistent with the rendering code. #251

Closed ClemRz closed 3 years ago

ClemRz commented 3 years ago

In https://github.com/day8/re-com/blob/5655dee6597051b69b08a5450f36edd56b07710e/src/re_com/modal_panel.cljs#L18 the validation limits to :container meanwhile in the code that renders the modal (lines 616, 68 and 72) it is used :child-container making this feature unusable.