search

day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
796 stars 147 forks source link

Tour component demo breaks on clicking "Start Tour!" button #303

Closed zackteo closed 2 years ago

zackteo commented 2 years ago

As mentioned, https://re-com.day8.com.au/#/tour breaks when the "Start Tour!" button is clicked.

Have tested on both chromium and firefox.

MawiraIke commented 2 years ago

Upon further investigation, it seems like this issue is caused by the changes done by the add-at-macro script. Specifically, the make-tour-nav function does not parse its parameters as a map but individually which breaks when we add extra arguments but fail to manually add them in the function parsing as parameters.

Pushing a fix for this issue.