search

day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
796 stars 147 forks source link

Conflicting documentation in splits #310

Closed MawiraIke closed 2 years ago

MawiraIke commented 2 years ago

In the documentation of splits, the parts option is indicated to expect a left and right assignment in h-split. However, it seems to use the top and bottom assignments like v-split in the code. E.g. for h-split left. There is a comment in the code close by msedge_3R4QihIolg

Assuming this, should we change the documentation to :top and :bottom for h-split?

superstructor commented 2 years ago

Nope the comment would be in regards to the css class rc-h-split-top specifically.

left/right is the correct terminology for h-split in all cases.

top/bottom is the correct terminology for v-split in all cases.