Removed deprecated usage of react dom node

day8 / re-com

A ClojureScript library of reusable components for Reagent

https://re-com.day8.com.au

MIT License

796 stars 147 forks source link

Removed deprecated usage of react dom node #334

Closed RolT closed 5 months ago

RolT commented 8 months ago

Using react refs in favor of react dom node. This PR fixes #329.

I tried to minimize changes, but by setting ref to inner components directly we could remove some parts of the dom navigation code (for instance, for filter-text-box, we can set the ref in the :input element and remove the call to -firstChild).

kimo-k commented 5 months ago

Merged, but with the idiom promoted by reagent instead of react/createRef (f974e64). I think it works just as well, but let me know if there's any issue. Thanks!