day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
796 stars 147 forks source link

recent changes to v-table still has rendering issues in 2.21.4 #341

Closed hipitihop closed 1 month ago

hipitihop commented 1 month ago

e.g. this when in table mode in results for Curve8.

image

Reverting to v2.19.0 corrects the issue

kimo-k commented 1 month ago

Hey @hipitihop,

A while back, I changed the signature of simple-v-table's column-header-render function. I should have known this might be a breaking change. Only simple-v-table is affected, not v-table.

When users pass in their own function for the :column-header-render prop, it needs to have the new signature: a single map of keyword arguments, not positional arguments.

The changes above should be all we need to fix our prod repos.