search

day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
800 stars 145 forks source link

title: forces margins inconsistanly #349

Open hipitihop opened 1 week ago

hipitihop commented 1 week ago

The title component forces top-margin and bottom-margin by default, not sure why, but it is also difficult/impossible to override as it uses !important

Default: image

[[rc/title
   :level :level2
   :label "My Title"]

If I use :parts :wrapper to set top bottom margin, it is ignored. If I use :style {:margin-bottom "0px" :margin-top "0px"} only the top takes.

I find 9/10 I give up on using title because the defaults don't suit the container and the overrides are as much effort as using normal rc/label and restyle with larger font etc.

kimo-k commented 1 week ago

I find this annoying too. It seems to throw off our fibonacci-based layout convention.