search

day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
797 stars 146 forks source link

Allow button label to be passed in to alert box. [re-com "0.8.0"] #85

Closed benhowell closed 8 years ago

benhowell commented 8 years ago

For those not using material design icons, the :closeable? arg on alert-box does not work as it's hard coded as a material design icon. Allowing the button label or button itself to be passed in would be nice.

https://github.com/Day8/re-com/blob/master/src/re_com/alert.cljs#L32

Gregg8 commented 8 years ago

Material design icons are used all over the place in re-com, so this would not be a small change to do it properly. If it'is really important for this to be included, then could you please submit a PR.

benhowell commented 8 years ago

No, that's fine. I'll close the issue. Thanks!