Closed smee closed 6 years ago
React 16 is the issue, I’ll get a release out shortly that works with React 16.
I tried reproducing this issue on todomvc, and I couldn't. Do you have a reproducible case I can look at?
I think the problem is that the inlined reagent still assumes that react is available in version 15, see util.cljs#L7-L11 which references the global js/react
variable. createClass
was removed in version 16.
I will try to recreate my local dependencies in TodoMVC.
Okay, please see the adjusted dependencies in my fork at https://github.com/smee/re-frame/commit/b751a1d81169ab30a5d3e79b4abe01fcea405a50
I used the same set of dependencies and I see the same error in my console. The root call is day8$re_frame$trace$inject_devtools_BANG_
btw.
I've pushed a react-16 branch which has updated the Reagent dependencies. I've deployed a snapshot release: 0.1.16-20180126.084837-2
. That should work, let me know if it doesn't.
I'll probably need to do parallel releases for a little while if it is not going to be possible to support both React versions with one bundled Reagent. That will probably look like doing two releases in parallel, one with a react-16 qualifier. I'm not 100% on that yet.
Thanks a lot! Works great.
I've released 0.1.16-react16
as a parallel version to 0.1.16
. See https://github.com/Day8/re-frame-trace#installation for more details.
With
[day8.re-frame/trace "0.1.15"]
I see an error after cleaning and rebuilding my application:Maybe this version is not compatible with my other dependencies?
0.1.14
used to work with them. They areAnything obvious I could try?