Broken Code formatting in Events tab.

mike-thompson-day8 commented 4 years ago

This change to HTML styles broke the code formatting at the top of the Events tab.
https://github.com/day8/re-frame-10x/commit/40e7e7da18c9cc3b755d0247f5b41a754c4e0a07

After this change, the code shown (at the top of the events tab) never had newlines, and was always string onto one line.

Gregg8 commented 4 years ago

Some background:

There have been three related styling commits this year:

Originally, 10x only really targeted Chrome and this was work to make it display better in other browsers, but specifically MS Edge, which unfortunately is the browser used in Microsoft 365 JS Add-ins.

Icons (which are svg) did not display at all in Edge and so it was determined this was because the reset CSS was not working and so these were the changes made.

As it happens, the third commit caused the unwanted effect of removing all newlines from the displayed event code in the Events tab.

On looking into this, it's the [:pre] that is responsible for adding the newlines and the new reset CSS messes with this, so we need to target the styling of that, but making sure nothing else breaks.

Additional TODO: Currently, the svg arrows display as a grey button under Edge so need to look into that as well...