day8 / re-frame-10x

A debugging dashboard for re-frame. X-ray vision as tooling.
MIT License
632 stars 68 forks source link

Add settings option to enable or disable rendering of path annotations #345

Closed MawiraIke closed 2 years ago

MawiraIke commented 2 years ago

Fixes #341 Adds a new settings option to toggle rendering of path annotations

preview

mike-thompson-day8 commented 2 years ago

Now I'm seeing this option in settings, I'm having second thoughts. This option should probably be a tick box in the app-db tab itself, closer to where it has its effect (at the expense of some vertical real estate in that tab).

So, I would suggest:

MawiraIke commented 2 years ago

Sounds great @mike-thompson-day8 , I will proceed to make that addition to this PR.

MawiraIke commented 2 years ago

This PR has been updated. The tickbox is now located in the app-db tab. i.e

preview

mike-thompson-day8 commented 2 years ago

@MawiraIke Okay, looking good. One thing: can we get the information popup to be about 60 to 80 characters wide. That provides for the best reading experience. Very wide text is hard to read.

I'll leave any further code review to @superstructor

MawiraIke commented 2 years ago

This PR has been updated with the recommended changes.

superstructor commented 2 years ago

Good to see that the local-storage/save interceptor is being used so that this setting will survive page refreshes.

Overall looks good, thanks @MawiraIke 👍🏻