Closed MawiraIke closed 2 years ago
Now I'm seeing this option in settings, I'm having second thoughts. This option should probably be a tick box in the app-db tab itself, closer to where it has its effect (at the expense of some vertical real estate in that tab).
So, I would suggest:
app-db
panel with the label "data path annotations". to the right of this tickbox there is an info button (?) that causes a popup containing the following explanatory text ...
When ticked, you can right-click on the rendered data (below) to obtain path data and cause focus etc. But this feature comes with a performance hit on rendering which is proportional to the size/depth of app-db. So, if your app-db is large and you are noticing a delay/pause in rendering app-db, untick this option to get better performance.
Sounds great @mike-thompson-day8 , I will proceed to make that addition to this PR.
This PR has been updated. The tickbox is now located in the app-db tab. i.e
@MawiraIke Okay, looking good. One thing: can we get the information popup to be about 60 to 80 characters wide. That provides for the best reading experience. Very wide text is hard to read.
I'll leave any further code review to @superstructor
This PR has been updated with the recommended changes.
Good to see that the local-storage/save
interceptor is being used so that this setting will survive page refreshes.
Overall looks good, thanks @MawiraIke 👍🏻
Fixes #341 Adds a new settings option to toggle rendering of path annotations