day8 / re-frame-10x

A debugging dashboard for re-frame. X-ray vision as tooling.
MIT License
631 stars 68 forks source link

Bump re-highlight to 2.0.2 #383

Closed WindOfMind closed 1 year ago

WindOfMind commented 1 year ago

re-highlight 2.0.1 causes warnings with a message: reagent.dom/dom-node is deprecated.

------ WARNING #1 - :fn-deprecated ---------------------------------------------
 Resource: re_highlight/core.cljs:33:27
--------------------------------------------------------------------------------
  30 | 
  31 | (defn did-mount
  32 |   [this]
  33 |   (when-let [el (gobj/get (rdom/dom-node this) "firstChild")]
---------------------------------^----------------------------------------------
 reagent.dom/dom-node is deprecated
--------------------------------------------------------------------------------
  34 |     (hljs-highlight-element el)))
  35 | 
  36 | (defn did-update
  37 |   [this old-argv old-state snapshot]
--------------------------------------------------------------------------------

------ WARNING #2 - :fn-deprecated ---------------------------------------------
 Resource: re_highlight/core.cljs:38:27
--------------------------------------------------------------------------------
  35 | 
  36 | (defn did-update
  37 |   [this old-argv old-state snapshot]
  38 |   (when-let [el (gobj/get (rdom/dom-node this) "firstChild")]
---------------------------------^----------------------------------------------
 reagent.dom/dom-node is deprecated
--------------------------------------------------------------------------------
  39 |     (gobj/set hljs-init-highlighting "called" false)
  40 |     (hljs-highlight-element el)))
  41 | 
  42 | (defn render
--------------------------------------------------------------------------------

Version 2.0.2 resolves this issue.

scarytom commented 1 year ago

@superstructor are you able to merge this please? The console warnings are quite annoying, and can mask real issues.

superstructor commented 1 year ago

@scarytom I'm no longer at @day8 so do not have access to merge PRs. Hopefully @Gregg8, @hipitihop, @stumitchell or @mike-thompson-day8 can merge it for you.

hipitihop commented 1 year ago

Thanks @WindOfMind