search

day8 / re-frame-10x

A debugging dashboard for re-frame. X-ray vision as tooling.
MIT License
631 stars 68 forks source link

Keyboard settings #386

Closed kimo-k closed 1 year ago

kimo-k commented 1 year ago

https://github.com/day8/re-frame-10x/issues/314

kimo-k commented 1 year ago

Different defaults per browser could work, but could also lead to more confusion. I imagine the new option to set your own binding, and the new docs for programmatically opening the panel, should be relief enough for anyone who is currently hacking their Ctrl-h somehow.

How do we feel about Ctrl-Shift-X? It seems unused by mainstream browsers.

Firefox does use it to switch text direction (such as for Arabic input), but only when a text input element is focused. Conveniently, 10x ignores the key event in this situation.

It is used by VSCode and Teams to open panels, but that's probably okay.

sirmspencer commented 1 year ago

Anything for the readme?

kimo-k commented 1 year ago

Hey @sirmspencer, I did notice an inconsistency in the readme for this. I fixed that & added a mention of the settings. Let me know if any other particulars come up.

sirmspencer commented 1 year ago

Looks good, thanks.

mike-thompson-day8 commented 1 year ago

There is mention of ctrl-h in re-frame-template README ... Good idea to bump it's deps in that template too.

On Thu, 6 July 2023, 10:37 am Matthew Spencer, @.***> wrote:

Looks good, thanks.

— Reply to this email directly, view it on GitHub https://github.com/day8/re-frame-10x/pull/386#issuecomment-1622740709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXESIHAMDS4TOSXUDE65WDXOYCENANCNFSM6AAAAAAZKY6G5Y . You are receiving this because you are subscribed to this thread.Message ID: @.***>