search

day8 / re-frame-10x

A debugging dashboard for re-frame. X-ray vision as tooling.
MIT License
636 stars 68 forks source link

[Bug]: "guide me to greatness" did not guide me to greatness #395

Closed enigma closed 1 year ago

enigma commented 1 year ago

What happened?

In the timing panel the "guide me to greatness" link does not lead anywhere, upon inspection it does not have any href attr.

Is it possibly that https://github.com/day8/re-frame-10x/blob/master/src/day8/re_frame_10x/panels/timing/views.cljs#L59 should use rc/hyperlink-href instead?

10x Version

1.7.0

Reagent Version

1.2.0

React Version

18

re-frame Version

1.2.0

What browsers are you seeing the problem on?

Chrome

Relevant console output

No response

kimo-k commented 1 year ago

Thanks, I found a few other places to fix as well.