day8 / re-frame-10x

A debugging dashboard for re-frame. X-ray vision as tooling.
MIT License
636 stars 68 forks source link

[Bug]: 10x crashes with console error: Invalid number #401

Closed hipitihop closed 1 year ago

hipitihop commented 1 year ago

What happened?

Exception in console after an error in a subscription. 10x does not come up, even after refresh whole page.

Note: after rolling back to prior version, I see the issue there too.

Error: Invalid number: 0e5d83b7-f22a-4762-8450-36be7d65ef10.
    at new cljs$core$ExceptionInfo (core.cljs:11623:11)
    at Function.eval [as cljs$core$IFn$_invoke$arity$3] (core.cljs:11655:5)
    at Function.eval [as cljs$core$IFn$_invoke$arity$2] (core.cljs:11653:16)
    at Function.eval [as cljs$core$IFn$_invoke$arity$variadic] (errors.cljs:37:13)
    at Function.eval [as cljs$core$IFn$_invoke$arity$variadic] (errors.cljs:43:4)
    at Object.cljs$tools$reader$impl$errors$throw_invalid_number [as throw_invalid_number] (errors.cljs:81:4)
    at Object.cljs$tools$reader$edn$read_number [as read_number] (edn.cljs:214:14)
    at Function.eval [as cljs$core$IFn$_invoke$arity$4] (edn.cljs:406:42)
    at eval (edn.cljs:176:22)
    at Object.cljs$tools$reader$edn$read_delimited [as read_delimited] (edn.cljs:176:21)

10x Version

1.8.0

Reagent Version

1.2.0

React Version

17.0.2

re-frame Version

1.3.0

What browsers are you seeing the problem on?

Chrome

Relevant console output

Preceding console error

#error {:message 
"Invalid number: 0e5d … 2-8450-36be7d65ef10."
, :data {:type :reader-exception, :ex-kind :reader-error}}
reportError @   voz-rf.js:1286
env.evalLoad    @   voz-rf.js:1399
(anonymous) @   voz-rf.js:1823
hipitihop commented 1 year ago

Update: I went through all keys in devtools -> Application -> local storage -> locahost and removed all 10x keys manually... now 10x starts up again

kimo-k commented 1 year ago

I think 6303fcfa10f253333dea08cd3a47d393fdb37776 fixes this.

kimo-k commented 1 year ago

Fixed in 1.8.1

hipitihop commented 1 year ago

@kimo-k I think the following crash in 1.7.0, and not fixed by 1.8.1 may be related. I had to do the same thing and manually go through local storage and delete all 10x keys to get it running again.

image

kimo-k commented 1 year ago

Interesting. Let me know if you find a way to reproduce.

I recently updated the docs to emphasize factory reset. Hopefully it makes these kind of stateful bugs a little less daunting for our users.

hipitihop commented 1 year ago

@kimo-k Thanks. I'll keep an eye out but factory reset should be enough to resolve it if happens again. Closing