day8 / re-frame-10x

A debugging dashboard for re-frame. X-ray vision as tooling.
MIT License
631 stars 68 forks source link

[Bug]: ignored-events in project configuration are ignored. #414

Open sirmspencer opened 6 months ago

sirmspencer commented 6 months ago

What happened?

I'm following the readme to add ignored-events to the project configuration and they don't load in. I cleared my local storage before loading the app. I tried both the string and non string keyword.

:compiler-options  {:closure-defines {re-frame.trace.trace-enabled?        true
                                      day8.re-frame-10x.ignored-events
                                      "[:core/reset-idle-timer :core/track-session]"}

Factory Reset

10x Version

1.9.8

Reagent Version

1.20

React Version

17

re-frame Version

1.4.3

What browsers are you seeing the problem on?

Chrome

Relevant console output

No console output
sirmspencer commented 6 months ago

OK, I don't think they are ignored as much as causing an error. If I include day8.re-frame-10x.history-size 3, I can see that it only works if I remove day8.re-frame-10x.ignored-events

sirmspencer commented 6 months ago

I also tried a global event (no ns qualified :core/my-event) and it causes the same error. day8.re-frame-10x.ignored-events "[:noop]"