search

day8 / re-frame-debux

A fork of debux for tracing re-frame code (for eventual consumption by re-frame-10x)
Eclipse Public License 1.0
43 stars 7 forks source link

Require tracing macros from cljs #27

Closed mrichards42 closed 4 years ago

mrichards42 commented 5 years ago

I'm writing a re-frame app with most of my code in cljc files. This means my ns forms have to include reader conditionals when requiring day8.re-frame.tracing which makes for some long lines. This PR allows you to use the implicit refer sugar, like so:

(ns my.app
  (:require [day8.re-frame.tracing :refer [defn-traced fn-traced]]))

;; instead of something like:
(ns my.app
  (:require [day8.re-frame.tracing #?(:cljs :refer-macros :clj :refer) [defn-traced fn-traced]]))
danielcompton commented 5 years ago

Great, thanks for this! I often forget to do it. I'll try and take a close look soon and get this merged.

superstructor commented 4 years ago

Thanks @mrichards42 :+1: