search

day8 / re-frame-http-fx

A re-frame "effects handler" for performing Ajax tasks (via cljs-ajax)
MIT License
259 stars 27 forks source link

Prepare shift from XhrIo? #21

Closed Frozenlock closed 5 years ago

Frozenlock commented 6 years ago

As commented on #18, the next version of cljs-ajax is supposed to drop XhrIo.

It is intended that the default implementation for JavaScript uses XmlHttpRequest directly and XhrIO is deprecated in 0.8. Be warned.

Is this effect handler going to be updated to use the different backend, or will it drop cljs-ajax?

hipitihop commented 6 years ago

Apologies for being so tardy tending to issues and pr's. I haven't reviewed implications or made any decisions yet regarding the backend and dependence on cljs-ajax and in turn XhrIo. I think any consideration for moving away should also include looking at Fetch to see if it offers anything https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API Comments & suggestions welcomed

dgroulx commented 5 years ago

An upvote for at the very least letting the user override the default :api key.

mike-thompson-day8 commented 5 years ago

I'm closing this (as part of some spring cleaning)

This issue was opened in 2017, and the move away from XhrIO has never happened. Neither do I suspect it will ever happen.

@dgroulx I can't parse your comment about overriding :api - there's insufficient detail given - and it seems to be a feature request and unrelated to moving away from XhrIO. Please open a separate issue describing the problem in more detail.