search

day8 / re-frame-http-fx

A re-frame "effects handler" for performing Ajax tasks (via cljs-ajax)
MIT License
259 stars 26 forks source link

compiler warning with clojurescript 1.9.946 -> please bump cljs-ajax version #24

Closed raymcdermott closed 6 years ago

raymcdermott commented 6 years ago

Version 0.1.4 of re-frame-http-fx

$ lein karma-once
Compiling ClojureScript...
Compiling "resources/public/karma/test.js" from ["test/cljs" "src/cljs"]...
WARNING: uri? already refers to: cljs.core/uri? being replaced by: cognitect.transit/uri? at line 332 resources/public/karma/test/cognitect/transit.cljs
Successfully compiled "resources/public/karma/test.js" in 37.9 seconds.

Version 0.1.5-SNAPSHOT of re-frame-http-fx, after I cloned it and bumped cljs-ajax from 0.5.8 to 0.7.3

$ lein karma-once
Compiling ClojureScript...
Compiling "resources/public/karma/test.js" from ["test/cljs" "src/cljs"]...
Successfully compiled "resources/public/karma/test.js" in 40.251 seconds.

I don't want to make a PR out of this as you might have other issues but happy to do so if you like.

raymcdermott commented 6 years ago

The issue comes from an outdated version of transit in cljs-ajax but the net effect is that you have to bump ;-)

danielcompton commented 6 years ago

I've cut a new release in http-fx-0.1.5-20180130.200601-1, can you give it a go and let me know how you get on? If all is well I'll do a full release.

raymcdermott commented 6 years ago

It's a small sample but testing my app (with re-frame-test, karma and manually) all works.

danielcompton commented 6 years ago

0.1.5 is out and fixes this. Thanks for the report!