day8 / re-frame-http-fx

A re-frame "effects handler" for performing Ajax tasks (via cljs-ajax)
MIT License
259 stars 27 forks source link

Warning when compiling with infer-externs enabled #38

Closed svdm closed 5 years ago

svdm commented 5 years ago

This is a case of the same bug as Day8/re-frame#512: here, the use of js/goog.net.Xhrio instead of just goog.net.Xhrio in request->xhrio-options triggers a warning when using advanced optimisations with infer-externs enabled:

WARNING: out/inferred_externs.js:9: WARNING - name goog is not defined in the externs.
goog.net;
^^^^

Jul 22, 2019 4:47:01 PM com.google.javascript.jscomp.LoggerErrorManager println
WARNING: out/inferred_externs.js:10: WARNING - name goog is not defined in the externs.
goog.net.Xhrio;
^^^^