Open danielcompton opened 6 years ago
mike-thompson-day8
commented
4 years ago I don't understand what's proposed in this issue yet but, for the record, I followed the provided link and it looks as though reagent and re-frame were recently deleted from oss-canary.
See https://github.com/cljs-oss/canary/commit/16de8e6fb1eb1a32b5ec364dbaad2fd1b2d80676
victorb
commented
4 years ago @mike-thompson-day8 it looks like re-frame had to be forked to support things like running the tests headlessly (switching chrome for phantomjs [although chrome can be run headless if you have chromedriver in the CI environment]), support for env vars to set the clojurescript version and config for running TravisCI tests.
Suggestion is to upstream those changes to this repository, so they will always be up-to-date, instead of having to maintain a separate, forked version, where any fixes to this repository would have to be merged, and potential merge conflicts resolved.
mfikes
commented
4 years ago I think something with PhantomJS was causing issues with the latest generated JavaScript and evidently moving to something more modern (Puppeteer?) can resolve the issues. I tried futzing with it and, not being well versed in web-dev technologies, didn't make any progress.
Ideally, yeah, if re-frame joined the Canary project, then re-frame team members would be notified for Canary build failures, be able to maintain things with respect to re-frame master, etc. (The chkup organization is a place where I am personally running Canary CI for other projects.)
superstructor
commented
4 years ago The changes for this repository are done, now preparing an associated PR for cljs-oss/canary.
@mfikes has already done the hard work of creating a canary config for https://github.com/cljs-oss/canary/tree/master. We should think about merging it in to this project, so we can run tests against the latest ClojureScript and detect any breaking changes well in advance.
@mike-thompson-day8 what do you think?