dannyfreeman
commented
2 years ago I put this in the issue, but wanted to drop it here too. It may be worth figuring out how to change re-frame such that this warning is not necessary.
I made this branch a while back to explore what seems to be a reasonable solution to the problem: https://github.com/day8/re-frame/compare/master...dannyfreeman:bypass-subscription-cache-outside-reactive-context
In short, when the current call to subscribe is not happening in a reactive context and a subscription is not already cached, then bypass the subscription cache. Just return a new reaction. If the subscription was already cached then any code can grab and derefence that cached subscription (which is now only cached in reactive contexts, so something will eventually clean it up).
superstructor
I saw the help wanted tag on issue #740 and decided to open a PR for it
This will log warnings to the console every time a call to subscribe is made in a place it shouldn't be called, like event handlers.
Here is what the warning looks like in firefox:
Right now it is printed as a warning. It may be more useful to print it as an error so the user can see the stack trace and find what code triggered the message.