Control points rotation is wrong

daybrush / moveable

Moveable! Draggable! Resizable! Scalable! Rotatable! Warpable! Pinchable! Groupable! Snappable!

https://daybrush.com/moveable/

MIT License

10.08k stars 618 forks source link

Control points rotation is wrong #151

Closed ladifire closed 4 years ago

ladifire commented 4 years ago

Environments

Framework name: React
Framework version: 16
Component name: Control points
Component version:
Testable Address(optional): No

Description

Please this gif. When using rectangle shape for control points. The rotation set for them is wrong.

Please fix this in future version. captured

daybrush commented 4 years ago

@ladifire

What is the component version? This problem has been solved for a long time?

ladifire commented 4 years ago

This bug is in react-moveable package, please see this demo https://codesandbox.io/s/react-moveable-demo-66w9h

daybrush commented 4 years ago

@ladifire

This problem will be solved by updating react-moveable.

ladifire commented 4 years ago

Yes! thankyou!

iprasadg commented 4 years ago

@daybrush In ngx-movable (version 0.9.3) also the direction cursor (cursor pointer) is not updating.

daybrush commented 4 years ago

@iprasadg

What does it mean that the direction cursor doesn't update? is it custom CSS? Can you give me a gif?

iprasadg commented 4 years ago

@daybrush Without rotate cursor styles are correct i.e showing according to direction. But, after rotate cursor style should get updated. It is showing previous style of cursor. See the following gif

cursor

daybrush commented 4 years ago

@iprasadg

Oh I didn't think that part. This may take a while, but I'll fix it soon.

ladifire commented 4 years ago

This is so difficult to fix, because it's cursor, not part of component. I find out that Figma (https://www.figma.com/) generate cursor for every rotate then assign each cursor for each rotation position.

daybrush commented 4 years ago

@ladifire

I'm thinking about it too, but probably an svg cursor. I'm thinking of changing the angle every 10 degrees.

daybrush commented 4 years ago

@ladifire @ladifire There may be browser support issues, so the default is likely to be 45 degrees.

ladifire commented 4 years ago

Your last commit not working with edge={true} captured (3)

daybrush commented 4 years ago

@ladifire @iprasadg

A new version has been released.

moveable 0.13.4
react-moveable 0.16.6
preact-moveable 0.15.5
ngx-moveable 0.9.4
svelte-moveable 0.4.4

Update to the new version. Thank you :)

ladifire commented 4 years ago

Thanks @daybrush, it's sunday but you've worked hard!

iprasadg commented 4 years ago

@daybrush Updated to the new version. Thanks for resolving issue. 👍