Vertical line always selected even if not within selection

daybrush / selecto

Selecto.js is a component that allows you to select elements in the drag area using the mouse or touch.

https://daybrush.com/selecto

MIT License

2.04k stars 82 forks source link

Vertical line always selected even if not within selection #117

Closed m-damien closed 1 year ago

m-damien commented 1 year ago

Environments

Framework name: React
Framework version: 18.2.0
Component name: Selecto
Component version: 1.20.3
Testable Address(optional): https://codesandbox.io/s/crazy-franklin-o5fe10

Description

Thank you for this library, it has been a pleasure to work with it so far! I am having an issue with vertical SVG lines. They seem to be getting selected even when they are not part of the selection: line_selection I was able to reproduce the issue starting from one of the examples from the Storybook (see the testable address above). Seems to be fine with horizontal line, or lines that are not perfectly vertical.

daybrush commented 1 year ago

@m-damien

lit-selecto 1.21.0
preact-selecto 1.18.0
react-selecto 1.21.0
selecto 1.21.0
svelte-selecto 1.21.0
vue-selecto 1.21.0
vue3-selecto 1.7.0
ngx-selecto 1.21.0

selecto's new version is released.

Check it again.

m-damien commented 1 year ago

That was impressively quick! I tried the new version, the problem is completely fixed.

Thanks heaps!