search

daybrush / selecto

Selecto.js is a component that allows you to select elements in the drag area using the mouse or touch.
https://daybrush.com/selecto
MIT License
2.04k stars 83 forks source link

Feature Request: SelectByClick on mouseUp events #65

Open MW360 opened 2 years ago

MW360 commented 2 years ago

Environments

I am trying to integrate Selecto together with React Moveable into BigBlueButton as part of my Bachelor Thesis: bigbluebutton/bigbluebutton#13929, bigbluebutton/bigbluebutton#2351

It seems like SelectByClick only works on mouseDown events and not on mouseUp events. It would be great if there will be an option to configure that the Selection gets only added on mouseUp events.

daybrush commented 2 years ago

@MW360

So I will change the behavior. Thank you.

daybrush commented 2 years ago

@MW360

selecto's new version is released. Check it again.

clickBySelectEnd option is added.

https://github.com/daybrush/selecto#option-behaviors

Set options:

MW360 commented 2 years ago

Hi, thank you for implementing the feature!

Unfortunatly, it seems that my description of the feature was not detailed enough.

So I think the problem was this sentence of my description:

option to configure that the Selection gets only added on mouseUp events

I meant selection on mouseUp additionally to selection on drag. Further, the continueSelect and toogleContinue select should also work with selection on mouseUp. Also my idea was that selectFromInside should still be possible. So on drag, only the selection rectangle should be used for selection. On click on a single target without a further dragging, the element should be selected on mouseUp.

Sorry for my misleading description,

Best regards, Maximilian