search

dayglojesus / managedmac

Comprehensive Puppet module for OS X.
http://dayglojesus.github.io/managedmac/
Apache License 2.0
62 stars 21 forks source link

managedmac::ntp not idempotent #48

Closed dayglojesus closed 9 years ago

dayglojesus commented 9 years ago

This class uses a cheap method of keep the clock in sync. Each time puppet-agent runs, it uses an exec to toggle the service, thereby forcing an update. It's cheeky and guarantees a Puppet apply on each run, meaning it's not idempotent.

https://github.com/dayglojesus/managedmac/blob/master/manifests/ntp.pp#L99-L104

Maybe replace this with a periodic task?

dayglojesus commented 9 years ago

made ntp class idempotent by removing the ntp_sync resource. see comments for reasons.

fixed in 0.5.7