search

dayglojesus / managedmac

Comprehensive Puppet module for OS X.
http://dayglojesus.github.io/managedmac/
Apache License 2.0
62 stars 21 forks source link

Revert delint: c5ecc6ebab9fdbd22ad229248b368de0d8ec7ccb #68

Closed clburlison closed 9 years ago

clburlison commented 9 years ago

I recommend reverting commit c5ecc6ebab9fdbd22ad229248b368de0d8ec7ccb. Not sure what you were trying to accomplish with cleaning up the code here so feel free to revisit the change yourself or revert the code with this pull request. In the latest branch of 0.6.0 I am seeing the following:

error
Error: validate_re(): false does not match ["^true$", "^false$", "^10\\.\\d{1,2}\\.?\\d{0,2}$"] at /etc/puppet/environments/production/modules/managedmac/manifests/portablehomes.pp:479 on node 011-adm-maccb.example.com
Error: validate_re(): false does not match ["^true$", "^false$", "^10\\.\\d{1,2}\\.?\\d{0,2}$"] at /etc/puppet/environments/production/modules/managedmac/manifests/portablehomes.pp:479 on node 011-adm-maccb.example.com
clburlison commented 9 years ago

In hindsight I should have maybe just made an issue for this instead of a pull request...