search

dayhaysoos / use-shopping-cart

Shopping cart state and logic for Stripe
MIT License
907 stars 118 forks source link

(core): fix missing allowedCountries and billingAddressCollection for checkoutSingleItem #257

Closed ehowey closed 1 year ago

ehowey commented 2 years ago

checkoutSingleItem is not properly passing the values for allowedCountries and billingAddressCollection to Stripe.

This is my attempt at what I think a fix should be. As stated in my other PR I am not quite sure how to test this library in abstraction, but I think this should be the fix required to get it working, or very close to the fix.

netlify[bot] commented 2 years ago

👷 Deploy request for useshoppingcart pending review. Visit the deploys page to approve it

🔨 Explore the source changes: 7daa2f72d9ef0c75601aac903cf6a053a3638cb5

dayhaysoos commented 2 years ago

I'll give this a test later tonight!

dayhaysoos commented 1 year ago

Hey Eric, hope you're doing well. I've recently had some trouble getting the Gatsby example going, it's prob due to being outdated among other things. I'm not sure if you're still doing e-commerce things with USC or not, but for now, I'm going to close the gatsby related issues/PRs and maybe make a new issue for more working examples in USC. No pressure to add a gatsby example or anything, just updating you on why I'm going to be closing these out.

Hope you and your wife are doing great!