Closed hideokamoto-stripe closed 2 years ago
π· Deploy request for useshoppingcart pending review. Visit the deploys page to approve it
π¨ Explore the source changes: d934ea53ef3f90f9303bdecbbf626892e3431d61
Whoa, awesome! Going to take a look at this later today
Do you see this error when you run your tests or is this just my machine? Everything looks good to me otherwise, idk why this is a thing for me right now
Well... I can see another warning, but does not failed...
@hideokamoto-stripe I found which test is throwing this warning!
I'm having a hard time trying to resolve this, though :( Any ideas on what it could be?
Thanks! I found my mistake in this test code. I've fixed it and confirm to work well. https://github.com/dayhaysoos/use-shopping-cart/pull/259/commits/d934ea53ef3f90f9303bdecbbf626892e3431d61
Thanks!
@all-contributors please add @hideokamoto-stripe for code
@dayhaysoos
I've put up a pull request to add @hideokamoto-stripe! :tada:
I found the TODO comment in this file.
And I probably found the way to resolve the issue, so I'd made this Pull Request.
Usage
Provide a price id as string
Provide a object props includes a price id (and quantity)
Provide a object props includes a sku id (and quantity)
==
We can check the entire behavior in this file.
https://github.com/hideokamoto-stripe/use-shopping-cart/blob/feat/checkout-single-item/use-shopping-cart/react/test/index.test.js#L602-L724
Thanks!