Closed dayhaysoos closed 1 year ago
Right now the only thing that doesn't work is Gatsby but I'm okay with it for the time being.
getting some errors trying to run commands on this branch
npm test
and pnpm test
produces
npm run dev:cra
produces
Glad to see this merged. Will there be a new release soon @dayhaysoos ?
Hey @alec-bfa, I did the new release right after this merge!
Oh I missed it since I saw the latest release in github was from 2021. Thanks!
Overview
This is a PR that addresses quite a few things:
There's definitely still some work to do.
rollup -c -w
command doesn't work as well anymore. This allowed me to make updates to the library and see the changes get reflected. Right now, I have to manually update the bundle myself withrollup -c
and switch back and switch back to run the server again. Not sure how to fix this but I'll look into it.I finally addressed the warning that always got thrown in Next.js. Don't really need a review here because it was a one-liner that I sat on for about 2 years
Added a nextjs example to the examples folder, shout outs to @lmac-1 for her amazing starter repo. I pretty much dropped it in there.
Concerns
Ripping out yarn and migrating to pnpm is kinda scary. I still have a lot of errors/warnings being thrown by pnpm. So far, things are working better than they did before so that's a great sign, but not sure if this is safe enough to merge into master (I need to change to main soon).
Any insight would be appreciated.