search

daylen / stockfish-mac

Beautiful, powerful chess app for the Mac
http://stockfishchess.org/mac/
GNU General Public License v3.0
511 stars 116 forks source link

Undo feature #15

Closed maxgillett closed 10 years ago

maxgillett commented 10 years ago

Great job with the app Daylen!

I've added in some basic undo functionality. Pressing Ctrl-Z (or selecting Edit->Undo) removes the latest move and resets the board to reflect the penultimate position. I've also removed a few items that don't need to be checked in, and turned off code signing for development builds (let me know if this is a problem).

On an unrelated note, I haven't been able to analyze a position with the Stockfish engine without the program crashing (even when building from a fresh clone of the repo). Is this related to the code signing that you have in place? The engine analysis works when running the App Store version.

maxgillett commented 10 years ago

daylen/stockfish-mac#13

daylen commented 10 years ago

I'll take a look at the pull request soon. But yes, the engine binaries are code signed so they can only execute from what seems to be a signed parent process.

daylen commented 10 years ago

Thanks for doing this! I'm going to re-enable code signing for development builds. I feel that it's important to test code signing issues during development, and because the engine binaries are code signed, the parent app must be code signed as well.