search

daylen / stockfish-mac

Beautiful, powerful chess app for the Mac
http://stockfishchess.org/mac/
GNU General Public License v3.0
511 stars 116 forks source link

Crash upon opening PGN file #65

Closed nbca closed 4 years ago

nbca commented 4 years ago

Hi

I just downloaded stockfish and was trying to load a PGN file (attached). It crashed stockfish. I am able to open other files but this one crashed it.

My OS is Catalina 10.15.5 on MacBook Air 2020. I downloaded stockfish from the App Store today so I believe I have the latest build.

Thanks

CB - Chess Openings BASIC.pgn.zip

daylen commented 4 years ago

This is now fixed at HEAD, but it may take some time for the fix to reach the App Store. Thanks for reporting!

nbca commented 4 years ago

Thanks, is there a way I can update the file on my Mac to get it to work?

Thanks

From: Daylen Yang notifications@github.com Sent: Thursday, August 13, 2020 1:18:31 AM To: daylen/stockfish-mac stockfish-mac@noreply.github.com Cc: nbca nb.family.ca@gmail.com; Author author@noreply.github.com Subject: Re: [daylen/stockfish-mac] Crash upon opening PGN file (#65)

Closed #65https://github.com/daylen/stockfish-mac/issues/65.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/daylen/stockfish-mac/issues/65#event-3650444927, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQTC6HE7JJVBCRU7JKVSHIDSANZSPANCNFSM4P5SCVIQ.

daylen commented 4 years ago

I just submitted version 2.2.3 to Apple for review. It should be available soon!

The bug was that the app was trying to interpret the parentheses inside of comments. So if you have something like { my comment ( some text } where there is no closing ) then the app would crash. The app is now more resilient to this.

nbca commented 4 years ago

Thanks the update hit the App Store for laptops.

The same error seems to exist on the iPhone too. Can you please let me know if that bug is also fixed.

Thanks

From: Daylen Yang notifications@github.com Sent: Friday, August 14, 2020 11:38:35 PM To: daylen/stockfish-mac stockfish-mac@noreply.github.com Cc: nbca nb.family.ca@gmail.com; Author author@noreply.github.com Subject: Re: [daylen/stockfish-mac] Crash upon opening PGN file (#65)

I just submitted version 2.2.3 to Apple for review. It should be available soon!

The bug was that the app was trying to interpret the parentheses inside of comments. So if you have something like { my comment ( some text } where there is no closing ) then the app would crash. The app is now more resilient to this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/daylen/stockfish-mac/issues/65#issuecomment-674342548, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQTC6HHVD2XHE3T55LEDPA3SAX7LXANCNFSM4P5SCVIQ.

daylen commented 4 years ago

Unfortunately I don't develop the iPhone app. Have you tried an alternative app like https://itunes.apple.com/us/app/smallfish-chess-for-iphone/id675049147?mt=8?