search

daylerees / anbu

Anbu profiler for the Laravel PHP Framework.
308 stars 24 forks source link

Display query arguments into query logger view #19

Closed maximebeaudoin closed 10 years ago

maximebeaudoin commented 10 years ago

It would be interesting to see the arguments SQL queries in the tables of queries. However, I don't know if it would be better to add a column in the table instead.

daylerees commented 10 years ago

Hi there! Do the query arguments not appear within the query string for you? Laravel replaces the bindings before the query event is fired.

maximebeaudoin commented 10 years ago

No, i also dump queries into a log file since Laravel 4.0 and i have never seen arguments in queries. Currently i use Laravel 4.2.9.

query-screenshot

maximebeaudoin commented 10 years ago

I have take a look at https://github.com/laravel/framework/blob/4.2/src/Illuminate/Database/Connection.php#L715 and i don't see where the bindings is replaced in the query.

daylerees commented 10 years ago

Thanks man, I'll probably replace them myself then. Would be nice to have them in the query for clarity I think :)

maximebeaudoin commented 10 years ago

Agree, would be MUCH better.

daylerees commented 10 years ago

Could you put it in the extra column mate? I'll merge this until I get time to replace full bindings.

maximebeaudoin commented 10 years ago

Done, i added the style word-break: break-all; because sometime arguments list are very long and i don't want to break the table.

daylerees commented 10 years ago

Great, thanks :)