daylerees / colour-schemes

Colour schemes for a variety of editors created by Dayle Rees.
http://daylerees.github.io
Other
9.32k stars 1.62k forks source link

Fix for proper Vim/Vundle support #103

Closed JoshMock closed 10 years ago

JoshMock commented 10 years ago

Vim and Vundle expect color schemes to exist inside a colors directory rather than a root vim directory, so I've moved all .vim files and updated the README accordingly.

I also updated the build.xml, but I didn't see any instructions for how to run a build to test my change. Please let me know if I've somehow broken the build process and I'll make any necessary changes.

Hope this helps!

daylerees commented 10 years ago

Hold on a sec mate. The theme's are actually generated to that location. Could you remove the theme file moving from the PR, and I'll update the theme path then. Thanks man.

JoshMock commented 10 years ago

@daylerees My bad! I'm not a PHP guy so I couldn't figure out how to run the build.

Updated the commit to just have the build.xml change and the README update. Hopefully it's correct now.

JoshMock commented 10 years ago

Another thing I just noticed is that the file structure of having contrast and light directories makes those .vim files ignored by Vim. They'd all need to be directly inside the colors directory. Not sure if there's any easy way to fix that. I can take a crack once I know how to do a build. :smile:

daylerees commented 10 years ago

Hmm, I think I could add like a copy to the build file. Things are a little hacky right now to get things out the door, but they work. :)

edkolev commented 10 years ago

A hack is to run this after the .vim files are built

 mkdir -p vim-themes/colors && cp vim/*vim vim/light/*vim vim/contrast/*vim vim-themes/colors

Maybe this command could be set here, something like "post_build_command"

BTW thanks for the great project!

chriszarate commented 10 years ago

Thanks for this.

ciarand commented 10 years ago

@JoshMock thanks for the PR, I was just about to open a new issue when I saw this.

It's just an ant buildfile. You'll need composer installed tho, because it relies on blade templates from what I can tell. If you're on a Mac with homebrew, something like this'll get it:

# get apache ant
brew install ant
# go to build dir
cd build
# install composer (php dependency library: getcomposer.org)
curl -sS https://getcomposer.org/installer | php
# install dependencies (blade)
php composer.phar install
# go back up
cd -

If you're not, apt-get or the equivalent should be able to get ant and, assuming you have a copy of PHP installed (5.3+ I think), the rest is the same.

Then just run ant. It'll fail on the screenshots unless you have cuty_capt installed, but nbd. If I get a chance I'll see what I can do about making these work with vim, and maybe adding this info to the contributor's guide?

daylerees commented 10 years ago

Hey guys, I've got a better way of handling this. Don't worry I'll fix it soon :) thanks!

ciarand commented 10 years ago

Cool, thanks @daylerees!

daylerees commented 10 years ago

Added the moving to the build! Thanks :)