Updated Atom - Github theme

daylerees / colour-schemes

Colour schemes for a variety of editors created by Dayle Rees.

http://daylerees.github.io

Other

9.32k stars 1.62k forks source link

Updated Atom - Github theme #143

Closed rvanlaarhoven closed 9 years ago

rvanlaarhoven commented 10 years ago

Small colour fixes to match the originals a bit better

Anahkiasen commented 10 years ago

Shouldn't the original scheme manifest be modified ? https://github.com/daylerees/colour-schemes/blob/master/build/resources/themes/github.json

rvanlaarhoven commented 10 years ago

Hmm I missed this. The current atom theme does not match the colours in the github.json file though.

Guess it's going wrong over here then; https://github.com/daylerees/colour-schemes/blob/master/build/resources/patterns/atom/style.pattern#L100

daylerees commented 10 years ago

My Github theme isn't meant to be a replica. I've used a little more green in it.

rvanlaarhoven commented 10 years ago

I know, but the variables are black in Atom, in stead of the green like in Sublime for example. See the link in my previous comment. The foreground variable is being set to the .variable class