search

daylerees / colour-schemes

Colour schemes for a variety of editors created by Dayle Rees.
http://daylerees.github.io
Other
9.32k stars 1.62k forks source link

Themes look different than demo in PhpStorm 2016.1.2 #203

Closed alimfazeli closed 7 years ago

alimfazeli commented 8 years ago

For example this is how mellow contrast is supposed to look: screenshot from 2016-07-05 10-50-14

This is how it looks on my Jetbrains Phpstorm: screenshot from 2016-07-05 10-51-33

Why does this happen? Does anyone know a solution to the problem i have?

noplanman commented 8 years ago

I'm having the same issue with Earthsong, but it probably affects all themes. Maybe some keywords changed in the new versions of PhpStorm 😕

rsteinmann commented 7 years ago

Same Problem for me with Peacock, Mud, Keen ... tried couple of schemes but they all seem bugged. I use the 2016.2 Release of PHPStorm on Mac.

daylerees commented 7 years ago

Hi guys. I get this a lot (and need to find a better way to communicate it). The theme examples are from Sublime, which has a completely different theme rendering system. It can do things PHP storm can't (like have function and scope a different colour).

I haven't managed to improve the mapping for all themes yet, but if you try my other repo : https://github.com/daylerees/material-peacock - then I think you'll have better results.

Sorry about that!

noplanman commented 7 years ago

I get this a lot (and need to find a better way to communicate it).

I'd suggest to just write this somewhere. In the readme or demo page I couldn't find anything mentioning this. It might also be an idea to add a paragraph at the top of the demo page that explains "The following screenshots are made for Sublime, other editors may look different."

Thanks for all the grunt work by the way, must be insane.

Anahkiasen commented 7 years ago

It is in the README, it says the IntellijIDEA products are supported at 60% https://github.com/daylerees/colour-schemes#compatibility

noplanman commented 7 years ago

Yes I saw that, but what does that actually mean? That 60% of the theme colours work or that 60% of the themes themselves work or that 60% of the themes are fully compatible?

(I know I'm being a bit of a devil's advocate here)

I just think it would make sense to make a more tangible statement somewhere, which everybody can easily understand, because just stating the % of compatibility clearly isn't working. Doesn't this make sense?