daylightstudio / FUEL-CMS-Blog-Module

A blog module for FUEL CMS
18 stars 18 forks source link

errors after installing the blog module on Fuelcms 1.4 #27

Closed BartVertongen closed 6 years ago

BartVertongen commented 6 years ago

Severity: Runtime Notice

Message: Declaration of Fuel_blog::model() should be compatible with & Fuel_advanced_module::model($model = NULL) I did it manually and with the install script and I had the same problem. I am a new user of fuel it would take me too long to find the probem myself

daylightstudio commented 6 years ago

This looks symptomatic of a FUEL version issue. The Blog module requires FUEL 1.4. To check the version of FUEL, go to fuel/modules/fuel/config/fuel_constants.php.

http://docs.getfuelcms.com/installation/installing

BartVertongen commented 6 years ago

I checked it it says 1.4

daylightstudio commented 6 years ago

The blog module should be updated as well. The develop version had that fix in it for a while and was just merged over this week actually.

BartVertongen commented 6 years ago

I downloaded the module using zip yesterday. Would it be correct if I used git?

BartVertongen commented 6 years ago

I see develop and master are equal and last change was 6 months ago

daylightstudio commented 6 years ago

Does your libraries/Fuel_blog.php file have this change? https://github.com/daylightstudio/FUEL-CMS-Blog-Module/commit/0c50d55f9445989a52e0ffadcffc2b3d2dd95ea9

BartVertongen commented 6 years ago

I did not use git , I downloaded the zip.

biut in the file I see /**

class Fuel_blog extends Fuel_advanced_module {

protected $_settings = NULL;
protected $_current_post = NULL;

/**
 * Constructor
 *
 * The constructor can be passed an array of config values
 */
BartVertongen commented 6 years ago

so it extends fuel_advanced module

BartVertongen commented 6 years ago

ok I understand now yes the ampersand is gone

daylightstudio commented 6 years ago

Are you still seeing that error?

BartVertongen commented 6 years ago

If I put the & back it works

BartVertongen commented 6 years ago

but my fuel installation is not from this week but older, my blogs module is from this week

daylightstudio commented 6 years ago

Does your Fuel_advance_module class include the & in front of the model method? It shouldn't. The develop branch has it removed.

BartVertongen commented 6 years ago

No not in the class fileof Fuel_advance_module but in the Fuel_blog library I have to add it to make it work

daylightstudio commented 6 years ago

I see. The FUEL develop branch has that fix but the master branch does not.

BartVertongen commented 6 years ago

yes the model function in the class has it, has the ampersand. before I just looked in front of the class declaration (the start class ...) so if I remove it there it would be ok with the new blog module

BartVertongen commented 6 years ago

yes now it is ok. Why the ampersand ?, to make it faster because it is reference?

BartVertongen commented 6 years ago

ok thanks