search

daynefiler / tcpl

Former repository for the tcpl R package project. New repo:
https://github.com/USEPA/CompTox-ToxCast-tcpl
4 stars 5 forks source link

issue-9: escaped more NA values in .plotFit #10

Closed daynefiler closed 8 years ago

daynefiler commented 8 years ago

Addresses #9:

Similar to issue-2, the new nchar behavior with R3.3 was causing errors. Additional changes were made to prevent NA values being sent to nchar that were missed when fixing issue-2.

daynefiler commented 8 years ago

Matt, once you check this out we can merge it into master.

daynefiler commented 8 years ago

@ericwatt I probably deleted the wrong line -- I will take a look at it. I intended to just delete the commented rest of that line (it was from a very very old version).

daynefiler commented 8 years ago

@martino165 @ericwatt Does it look alright now?

martino165 commented 8 years ago

This looks great to me. I was going to recommend functionalizing the fix and it looks like you did that.

ericwatt commented 8 years ago

Yeah, that addresses my comment.