search

daynekilheffer / node-mpq

node.js port of mpyq (https://github.com/arkx/mpyq)
5 stars 2 forks source link

Move from Bigint to Bignum #14

Open skw opened 11 years ago

skw commented 11 years ago

Move from Bigint to Bignum, which has the same API but uses openssl as a dep instead of libgmp.

daynekilheffer commented 11 years ago

I had switched to another library locally, but found an issue with xor'ing with -1 (see #1). I haven't looked too much at the module you mentioned, but if it overcomes that, we should be good.

skw commented 11 years ago

I see, would it be hard to make a special case for negatives and strip off the leading sign bit and then deal with the resulting int as an unsigned int?

Disclaimer: It's been years since I dealt with this kind of stuff (and that was in C), I also haven't had time to look at all of your source-code yet.