search

daytimedrinkingclub / shipstation

Generate and manage your personal website and portfolio with ease
https://shipstation.ai/
73 stars 58 forks source link

Fix express bugs #12

Closed ptmaroct closed 2 months ago

ptmaroct commented 2 months ago
  1. Redirect non / ending sites to /, like https://shipstation.ai/site/sam-altman-spotify-portfolio-66Qmav1g/
  2. Reloading Code editor screen gives 404, https://shipstation.ai/project/traverse-legal-funny-website-TRWnRl8d
CodeMaster17 commented 2 months ago

Hey @ptmaroct I was looking forward to work on this bug. Can you please explain the bug "Redirect non / ending sites to /, like https://shipstation.ai/site/sam-altman-spotify-portfolio-66Qmav1g/ "

Thankyou

PREMPRAKASHSINGH commented 2 months ago

@ptmaroct point no 2 - Reloading Code editor screen gives 404 because that is a client side route /project/:shipId in App.jsx file.

When we refresh the page, the server tries to find a matching route on the server, but since the routing is handled by React on the client side, it returns a 404 error.

Raised a PR for fix of this - #29

pramaths commented 2 months ago

@ptmaroct resolved point no-1 Redirect non / ending sites to /, like https://shipstation.ai/site/sam-altman-spotify-portfolio-66Qmav1g/

Raised PR- https://github.com/daytimedrinkingclub/shipstation/pull/30

satvik2131 commented 2 months ago

is this issue solved ?