Repo related optimisations

daytimedrinkingclub / shipstation

Generate and manage your personal website and portfolio with ease

https://shipstation.ai/

73 stars 58 forks source link

Repo related optimisations #27

Open ptmaroct opened 2 months ago

ptmaroct commented 2 months ago

We need to ensure there are

no linting issues
unused imports
unformatted code
that client is built before pushing to main if there where any changes in frontend app, i.e., client folder

SAIF0556 commented 2 months ago

Can you please assign this issue to me?

ptmaroct commented 2 months ago

Can you please assign this issue to me?

You are free to work on it! We don't any assign issues, anyone can start working on it and submit PR

SAIF0556 commented 2 months ago

Can you please assign this issue to me?

You are free to work on it! We don't any assign issues, anyone can start working on it and submit PR Okay. Thank you.

Rehannn03 commented 2 months ago

What about the comments that are present in the code. Do we remove them or leave them as it is?

Kamlesh72 commented 2 months ago

@Rehannn03 I think @ptmaroct wants some Pre commit checks to ensure the following conditions are met. Or we can also create github workflows to handle this.

ptmaroct commented 2 months ago

Heroku deploys whatever is pushed to main. We currently manually run npm build before pushing to main on the client dir. It can be solved by simply adding an alias for npm golive = cd client && npm run build && git push origin main

ptmaroct commented 2 months ago

What about the comments that are present in the code. Do we remove them or leave them as it is?

Comments are fine

Rehannn03 commented 2 months ago

I guess we can add some pre commit hook so that it passes all the critera before getting pushed to main

ashishk1331 commented 2 months ago

Is this issue resolved? Please close the resolved one.

ptmaroct commented 2 months ago

@ashishk1331 not closed

ashishk1331 commented 2 months ago

@ptmaroct Added all asked requirements. Can you review the PR?