Open ptmaroct opened 2 months ago
Can you please assign this issue to me?
Can you please assign this issue to me?
You are free to work on it! We don't any assign issues, anyone can start working on it and submit PR
Can you please assign this issue to me?
You are free to work on it! We don't any assign issues, anyone can start working on it and submit PR Okay. Thank you.
What about the comments that are present in the code. Do we remove them or leave them as it is?
@Rehannn03 I think @ptmaroct wants some Pre commit checks to ensure the following conditions are met. Or we can also create github workflows to handle this.
Heroku deploys whatever is pushed to main. We currently manually run npm build before pushing to main on the client dir. It can be solved by simply adding an alias for npm golive = cd client && npm run build && git push origin main
What about the comments that are present in the code. Do we remove them or leave them as it is?
Comments are fine
I guess we can add some pre commit hook so that it passes all the critera before getting pushed to main
Is this issue resolved? Please close the resolved one.
@ashishk1331 not closed
@ptmaroct Added all asked requirements. Can you review the PR?
We need to ensure there are