search

daytonaio / daytona

The Open Source Dev Environment Manager.
https://daytona.io
Apache License 2.0
8.01k stars 770 forks source link

Target TUI breaks when terminal height is too low #769

Open Tpuljak opened 1 month ago

Tpuljak commented 1 month ago

Describe the bug daytona taget set form breaks when the terminal height is too low. Screenshot 2024-07-15 at 11 03 46

As seen in the screenshot, the form doesn't focus on the first item.

To Reproduce Steps to reproduce the behavior:

  1. Reduce terminal height
  2. daytona target set
  3. E.g. select docker provider and add a new target
  4. Observe that the first element is not in focus

Expected behavior The form should correctly focus each input item.

Desktop (please complete the following information):

lbrecic commented 1 month ago

/bounty $20

algora-pbc[bot] commented 1 month ago

💎 $20 bounty • Daytona

Steps to solve:

  1. Start working: Comment /attempt #769 with your implementation plan
  2. Submit work: Create a pull request including /claim #769 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

If no one is assigned to the issue, feel free to tackle it, without confirmation from us, after registering your attempt. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code.

Please respect others by working on PRs that you are allowed to submit attempts to.

e.g. If you reached the limit of active attempts, please wait for the ability to do so before submitting a new PR.

If you can not submit an attempt, you will not receive your payout.

Thank you for contributing to daytonaio/daytona!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @mihrab34 Jul 18, 2024, 7:47:55 PM WIP
mihrab34 commented 1 month ago

/attempt #769

abhishek818 commented 1 month ago

Seems here, the bubbletea guys decided to render last N no. of lines if the total no. of lines you render is greater than the terminal height..

Found another issue where they have talked about this and have solved the similar issue for Width word wrap.

Any thoughts over this?

Tpuljak commented 1 month ago

Ideally, we would solve it with some kind of scroll container. Perhaps we should wait for https://github.com/daytonaio/daytona/pull/799 to be solved. I believe scrolling is the default after upgrading the lib.