search

daz3d / DazToUnity

Daz to Unity Bridge
Apache License 2.0
34 stars 8 forks source link

Issue with uDTU GetLightDirection.hlsl #4

Closed JuanBarkhuizen closed 2 years ago

JuanBarkhuizen commented 2 years ago

Using Daz to unity 2022.1.3.7 and the 2020+ URP Plugin, On a fresh unity project (URP selected when projects are created) image Seems to work perfectly in Unity 2021.3 LTS URP 12.1.7 image However, in unity 2020.3 LTS URP 10.9 I get at least 2 errors ( You can still enter play mode and they don't always show up) image But when opening the LightDirectionURP the errors show up, Further when opening the other URP Shaders the most errors I've gotten regarding GetLightDirection.hlsl is 8. But I'm not sure how to trigger them all as I normally only get 2 or 3, all errors point to line 9 image

Not a major problem and I have not found any visual issues with it yet. but wanted to point it out

danielbui78 commented 2 years ago

Thanks very much for pointing this out. It's a bug that was fixed last year but apparently did not make it into the merged/refactored bridge. I will try to incorporate it into the next release.

FYI, this is the fix: https://forum.unity.com/threads/shader-graph-of-urp-of-2020-2-does-not-support-custom-nodes-and-more-issue.1030321/

JuanBarkhuizen commented 2 years ago

Awesome, Thanks.