dazedcat19 / FMD2

GNU General Public License v2.0
635 stars 58 forks source link

[bug] FMD hangs up without properly saving #706

Open l-l-l-l-l-l opened 3 years ago

l-l-l-l-l-l commented 3 years ago

Prerequisite

System information Windows 10 Pro

Describe the bug Sometimes, when performing updating tasks (like updating the series list or checking Favorites), if the task is stopped either by pressing the stop button or by restarting the application (e.g. when LUA modules have just been updated), the task just hangs and prevents the application from properly closing. In the case that download tasks have been added or changed states, they are not saved, while on the other side, if Favorites had detected a new chapter and the task for it had been added, that one is updated, making it so that the chapter becomes effectively "lost" on forced restart (i.e. the task for it disappears but it doesn't raise a match again in Favorites).

To Reproduce AFAIK it happens when the task is stopped at given points, so to reproduce it you just have to check for new chapters or update a site's list and then randomly terminate the task. If done on Favorites, it can be reproduced again easily by just stopping the check at the same point (same favorited series) it has hanged before.

Expected behavior Task is terminated, results updated and FDM can be closed without resorting to forced termination in Task MAnager or equivalent.

Screenshots image ^-Double trouble. It has been stopped like this for quite some time now.

Additional context Nothing comes to mind.

mastafrooper commented 2 years ago

I get the same issue myself. It's definitely repeatable if you try and stop an update check.

It does however randomly stall in checking for updates itself.

I have auto restart for module updates on and when I come back somedays FMD is close but sitting in Task Manager using CPU.

If I could turn on some kind of debug logging I could try and help narrow it down but the existing logs give no details.

It's definitely not world ending and it's kind of random when it happens without forcing it. Just kind of annoying.