search

dazinator / AspNetCore.LegacyAuthCookieCompat

Provides classes to encrypt / decrypt asp.net 2 / 3.5 / 4 and 4.5 FormsAuthenticationTickets (cookies) without relying on system.web
MIT License
74 stars 18 forks source link

Add ASP.Net 4.5 Compatibility #19

Closed lemoinem closed 5 years ago

lemoinem commented 5 years ago

Fixes #9 I've kept the default compatibility mode to Framework20SP2, as that's basically what it was before.

All tests are green. I've added new tests for Framework45. I've done my best to respect the code style. Please tell if anything needs to be changed.

lemoinem commented 5 years ago

PS: AppVeyor fails linked to missing %signingkey% config. I believe it's unrelated to my changes.

dazinator commented 5 years ago

Thanks for this. Yeah ignore the appveyor failure its not set up properly to deal with PR builds for this project. I'll review and merge - as long as there are no breaking changes introduced then I'll probably merge within next few days.

lemoinem commented 5 years ago

Hello, It's been almost two weeks... Any news? Did you have the time to take a look at it? Is there anything I could do for the PR to go forward? I'd very much prefer to be able to switch to a new version before I'm switching to something else.

dazinator commented 5 years ago

Hello - yeah sorry on holiday at the moment - back monday so will take a look then sorry for the delay :-)

lemoinem commented 5 years ago

No problem! Enjoy your holiday!

dazinator commented 5 years ago

@lemoinem the tests all pass and the api changes all look backward compatible so I have no problems merging this - thanks for the PR. One minor point before I do - would you be able to update the README.md so it mentions the new support you've added for asp.net 4.5 / compat mode?

lemoinem commented 5 years ago

@dazinator Great news! Here is the updated README.md

lemoinem commented 5 years ago

@dazinator Thanks for the merge! Would you mind publishing a new version to NuGet so we can start using this right away and remove our custom overriding code?

dazinator commented 5 years ago

It has published but it looks like the branch name has confused gitversion, and it calculated 4.5.0 as the next package version number. I might just leave it like that to be honest- you should find 4.5.0 on nuget.org (it takes a little while for nuget to validate)

dazinator commented 5 years ago

@lemoinem as per above this was pushed accidentally as package version 4.5.0 (gitversion issue) - I have just tagged it 1.3.0 and have triggered a push to nuget so it should appear shortly under the correct sem ver of 1.3.0. At which point I will unlist 4.5.0 on nuget.