dazinator / AspNetSolutionUpgradeTool

A utility that can be used to upgrade an ASP.NET 5 RC1 or RC2 based solution to ASP.NET Core 1.0.0 RTM.
MIT License
5 stars 2 forks source link

Consider renaming/rescoping the project to also deal with upcomming 1.0.0 ? #31

Closed ghost closed 8 years ago

ghost commented 8 years ago

I think this tool is wonderfull but I would like to use it not just for RC1-RC2 but also for RC1/2-1.0.0. The new version 1.0.0 is currently scheduled for 27th of June.

I just looked at the prelimary list of changes 1.0.0 which currently numbers about 15 breaking changes in addition to new version numbers. I therefore think this tool could be quite useful for changing to 1.0.0 also ?

dazinator commented 8 years ago

Thanks - I agree. All of the upgrade logic so far is basically contained within a set of IProjectUpgradeAction, ICsharpCodeUpgradeAction and ISolutionUpgradeAction's. Together, the set of those is the RC1 - RC2 upgrade. I;d most likely extend the tool to only Apply this set of actions if the current global.json was RC1. I'd then define the new set for the RC2 - 1.0.0 upgrade, and get the tool to run that set after the RC1 --> RC2 upgrade completes.

dazinator commented 8 years ago

I will revisit this when 1.0.0 is released, and most likely rename this repository after that support is added ;)

RehanSaeed commented 8 years ago

The word on the street is that VS will auto upgrade from RC2 to RTM.

dazinator commented 8 years ago

@RehanSaeed perfect. If only they could have done that for RC1 to RC2 :(

dazinator commented 8 years ago

Will close this for now, on the assumption that Microsoft are indeed taking care of this

ghost commented 8 years ago

@RehanSaeed Where have you heard this? I also heard that there would be no breaking changes but now I see there are plenty.

dazinator commented 8 years ago

Pretty sure it was mentioned in the community standup video.

dazinator commented 8 years ago

Looks like the upgrade experience provided by microsoft to go from RC2 to RTM is not exactly seemless there is still some work to be done.

At a minimum I could extend this tool to cater for that by:

  1. Upgrade the versions of packages used from RC2 to 1.0.0
  2. Upgrade global.json from preview1 to preview2
  3. Some of this stuff for those using EF: https://docs.efproject.net/en/latest/miscellaneous/rc2-rtm-upgrade.html
ghost commented 8 years ago

Very, very nice!