"**/.*" unexpectedly matches paths ending with dot

dazinator / DotNet.Glob

A fast globbing library for .NET / .NETStandard applications. Outperforms Regex.

MIT License

363 stars 27 forks source link

"**/.*" unexpectedly matches paths ending with dot #78

Closed oddstr13 closed 4 years ago

oddstr13 commented 4 years ago

Of the following tests, only /media/music/Foo B.A.R./epic.flac and /media/music/Foo B.A.R are correctly not matched

[InlineData("/media/music/Foo B.A.R.", false)] // matched
[InlineData("/media/music/Foo B.A.R./epic.flac", false)] // not matched
[InlineData("/media/music/Foo B.A.R", false)] // not matched
[InlineData("/Foo B.A.R.", false)] // matched
[InlineData("F.o.o.", false)] // matched
[InlineData("foobar.", false)] // matched

Could be related to #65 ?

dazinator commented 4 years ago

Apologies I missed this. Will take a look!

dazinator commented 4 years ago

Thanks for reporting @oddstr13 - good find, and sorry about any inconvenience caused. I have added a regression test case for this, and the fix will be released shortly in version 3.1.0

crobibero commented 4 years ago

Confirmed, 3.1.0 fixes the issue we had over in Jellyfin

dazinator commented 4 years ago

Excellent @crobibero thanks for confirming