dazzz1er / confer

Easy real-time chat for laravel 5 based websites and applications
133 stars 47 forks source link

bindShared not working? #45

Closed striderxfossility closed 5 years ago

striderxfossility commented 6 years ago

"Call to undefined method Illuminate\Foundation\Application::bindShared()"

I use laravelcollective/html.

What is the problem?

LarryBarker commented 6 years ago

I think it's something to do with the version of Laravel we're using because I'm having the same problem. I'm on 5.5 and can't get past registering the confer service provider 👎

Update: Did a quick search on google, and found out it has to do with Laravel deprecating the bindShared method in favor of using the 'singleton' method.

Look here to get started: #https://github.com/laracasts/flash/issues/55

But this example show's what you want: https://github.com/laracasts/flash/pull/53/commits/e1928bf4c1b14b7b373348bdcdf0c83cb2017e6f

In ConferServiceProvider.php register() method change::

$this->app->bindShared('push', function($app) {

to

$this->app->singleton('push', function($app) {
striderxfossility commented 5 years ago

Fixed

LarryBarker commented 5 years ago

@striderxfossility Was it my suggestion?

I think it's something to do with the version of Laravel we're using because I'm having the same problem. I'm on 5.5 and can't get past registering the confer service provider 👎

Update: Did a quick search on google, and found out it has to do with Laravel deprecating the bindShared method in favor of using the 'singleton' method.

Look here to get started: #laracasts/flash#55

But this example show's what you want: laracasts/flash@e1928bf

In ConferServiceProvider.php register() method change::

$this->app->bindShared('push', function($app) {

to

$this->app->singleton('push', function($app) {
striderxfossility commented 5 years ago

Greetings,

No i have still bindshared, because it is in Vendor, and i dont change anything in there, when i update it will be overwritten.

i forgot wat my fix was but i guessed it was: You should remove this outdated package - "illuminate/html": "^5.0" in composer.json