db-migrate / mongodb

mongodb driver for db-migrate
Other
25 stars 58 forks source link

Promises not removing the document in migration #39

Open wzrdtales opened 5 years ago

wzrdtales commented 5 years ago

I'm submitting a...

Current behaviour

exports.down = function(db) {
  return db.dropTable("pets");
};

// Returns:
[INFO] Defaulting to running 1 down migration.
collection migrations
collection pets

The code above remove the collection pets but doesn't remove the document in the migration collection.

exports.down = function(db, callback) {
  db.dropTable("pets1", callback);
};

// Returns:
[INFO] Defaulting to running 1 down migration.
collection migrations
collection pets1
[INFO] Processed migration 20190704145216-yop2
[INFO] Done

The code above works as expected, it removes the collection pets1 and remove the right document in the migration collection.

Expected behaviour

It should remove the right document in the migration collection when it succeed.

Environment


db-migrate@0.11.6
db-migrate-mongodb@1.5.0
Node version: v12.4.0
Platform:   Mac
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/78362554-promises-not-removing-the-document-in-migration?utm_campaign=plugin&utm_content=tracker%2F12293389&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F12293389&utm_medium=issues&utm_source=github).
wzrdtales commented 5 years ago

reported from https://github.com/db-migrate/node-db-migrate/issues/632

/cc @gmahe