Replace module imports with dynamic names to static

[alexeyoganezov]

Why:

To allow db-migrate usage in projects that use zeit/ncc or zeit/pkg for bundling. These tools cannot correctly analyze and bundle modules that relies on imports like require(path.resolve(__dirname, module)); that are used in ./lib/commands/index.js.

Implementation details:

• File ./lib/commands/index.js is removed as unnecessary.
• All ./lib/commands/*/** imports are rewritten as simple "require" without an intermediary.
• Stubs implementation in integration tests is fixed accordingly to changes (i.e new paths in imports).
• Drivers now can to be passed as an object (it creates tight coupling with driver module that wouldn't be included in a bundle otherwise)

Notes

• If you think these changes are unnecessary please feel free to close this PR.
• Not sure this PR follows all the guidelines and conventions, sorry for that.

[commitlint-wzrdtales[bot]]

There were the following issues with this Pull Request

• Commit: 4bae4dbfb3075fe57e248ab42b6ee051a2b757ff
  • ✖ message may not be empty , - ✖ type may not be empty
• Commit: 4b7a1f422c48b4474db064cb0f934126230cbb03
  • ✖ message may not be empty , - ✖ type may not be empty
• Commit: 203eccce58cfb42d972ae8ba95fbc50f1be8e3d4
  • ✖ message may not be empty , - ✖ type may not be empty
• Commit: efae9d0f85b34a2b073685db6ff769dd32f77ea8
  • ✖ message may not be empty , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

---

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

[commitlint-wzrdtales[bot]]

There were the following issues with this Pull Request

• Commit: 9811814b7afe6d9363cc921837c0ace3c1b6b74b
  • ✖ message may not be empty , - ✖ type may not be empty
• Commit: 27e998441c6fb945ebc4118efd523fb95dc00181
  • ✖ message may not be empty , - ✖ type may not be empty
• Commit: 7ea0b580105c69ff71c62fd6b301cde5276c3c0e
  • ✖ message may not be empty , - ✖ type may not be empty
• Commit: beb8e94ec4fec032fe7c6f693bd3925ae2ed0ec0
  • ✖ message may not be empty , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

---

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 58f7736cd18b46b82253d589d704d8a397900a73 into 4caaf3989e6fddec9423e1e6ca3f6176ff28c6dd - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[alexeyoganezov]

Nope, not stale.

[wzrdtales]

I wouldn't support this PR since it effectively destroys certain modularity and introduces too many unnecessary repetitions. Wouldn't it be a better solution if db-migrate could evaluate and emit all resources that may be loaded for such bundlers to bypass their shortcomings?

[wzrdtales]

@alexeyoganezov I will release a version that features an optional static loader that can be activated with an option switch, or environment switch. That should resolve this problem and still not affect other components of db-migrate.

[wzrdtales]

however that might still result in problems with plugin loading and other stuff. plugins can be already plugged in from the outside though.

[wzrdtales]

I backported another change to 0.11.x decided to include this one https://github.com/db-migrate/node-db-migrate/commit/e18304686036b35da8b73b2b8db3100c21f2791d

so with the option switch staticLoader set to true a static loader can be used, was tested with zeit/ncc.

[alexeyoganezov]

Thanks a lot. Will try this feature on the next project.