search

db-migrate / pg

A postgresql driver for db-migrate.
Other
67 stars 51 forks source link

fix(tests): fix tests on newer nodes by upgrading vows #43

Closed mmalecki closed 1 year ago

mmalecki commented 5 years ago

This seems to fix tests in node v10 and later.

Every other of our dependencies uses the ^ semver selector, so let's use that here too.

wzrdtales commented 5 years ago

Mhm, can't merge this. This unfortunately needs a bit of more effort. vows was intended to be fixed to this version, since there is a major bug in vows that has never been fixed. I do not recall exactly the problem, but here is the commit where I downgraded it again: https://github.com/db-migrate/node-db-migrate/commit/871abc4e7d76a39d0ab01cb6b1416267858ba5fc

So the effort needed here is to replace vows with lab, just lke the other tests that have been migrated already. If you want to give that a shoot, that would be awesome of course :)

mmalecki commented 5 years ago

Oh, no worries, did not realize this. Hm, I actually do have some spare time and interest in migrating things away from vows in general. I'll try to get the migration done this week.